Skip to content

make receive_timeout configurable #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

make receive_timeout configurable #96

merged 1 commit into from
Oct 3, 2024

Conversation

@michaelwang13
Copy link
Contributor

@michaelwang13 michaelwang13 commented Sep 30, 2024 •
edited
Loading

This exposes the httpclient receive_timeout property to be configurable by the end-user. This can be a useful setting to adjust when users hit errors like:

[warn]: #0 failed to flush the buffer. retry_times=0 next_retry_time=2024-09-26 18:35:54 +0000 chunk="REDACTED" error_class=HTTPClient::ReceiveTimeoutError error="execution expired"
2024-09-26T18:35:52.924897251Z 2024-09-26 18:35:52.924711734 +0000 fluent.warn: {"retry_times":0,"next_retry_time":"2024-09-26 18:35:54 +0000","chunk":"REDACTED","error":"#<HTTPClient::ReceiveTimeoutError: execution expired>","message":"failed to flush the buffer. retry_times=0 next_retry_time=2024-09-26 18:35:54 +0000 chunk=\"REDACTED\" error_class=HTTPClient::ReceiveTimeoutError error=\"execution expired\""}

@michaelwang13 michaelwang13 marked this pull request as ready for review September 30, 2024 18:49
@michaelwang13 michaelwang13 requested a review from a team as a code owner September 30, 2024 18:49
@michaelwang13
Copy link
Contributor Author

michaelwang13 commented Oct 3, 2024

@sumo-drosiek is it possible to get some eyes on this + release? the fluentd plugin is sending a significant number of duplicate/tripled up logs, and we need to be able to configure this setting.

@echlebek
Copy link

echlebek commented Oct 3, 2024

Hi Michael, Dominik isn't with Sumo any longer, but I'm happy to take a look at your PR.

@michaelwang13
Copy link
Contributor Author

michaelwang13 commented Oct 3, 2024

Thank you Eric, I appreciate it

echlebek
echlebek approved these changes Oct 3, 2024
View reviewed changes
Copy link

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@echlebek echlebek merged commit 9bc72be into SumoLogic:main Oct 3, 2024
1 check passed
@michaelwang13
Copy link
Contributor Author

michaelwang13 commented Oct 3, 2024 •
edited
Loading

Thank you Eric! It looks like I'm unable to cut a new release, can you do that as well so this is usable? @echlebek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@echlebek echlebek echlebek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelwang13 @echlebek